fix STOC_CHAT, CTOS_CHAT handling

[salix5]

No description provided.

[Copilot]

Pull Request Overview

This PR replaces the check_msg_size helper with inline bounds checks for chat packet lengths in both server and client handlers, and removes the now-unused helper from network.h.

• Remove check_msg_size from gframe/network.h
• Add explicit size validations in NetServer::HandleCTOSPacket and DuelClient::HandleSTOCPacketLan
• Remove helper call in NetServer::CreateChatPacket

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File	Description
gframe/network.h	Deleted the check_msg_size inline function
gframe/netserver.cpp	Replaced chat‐length helper with direct checks; removed helper use in CreateChatPacket
gframe/duelclient.cpp	Added inline STOC_CHAT size validations; removed check_msg_size call

Comments suppressed due to low confidence (1)

gframe/netserver.cpp:368

• Without a size check on src_size, this memcpy may overflow the src_msg buffer. Reintroduce a bounds check (e.g. ensure src_size <= LEN_CHAT_MSG * sizeof(uint16_t)) before copying.

std::memcpy(src_msg, src, src_size);

[purerosefallen]

what did this PR actually do?

another descless one

[salix5]

This PR replaces the check_msg_size helper with inline bounds checks for chat packet lengths in both server and client handlers, and removes the now-unused helper from network.h.

• Remove check_msg_size from gframe/network.h
• Add explicit size validations in NetServer::HandleCTOSPacket and DuelClient::HandleSTOCPacketLan
• Remove helper call in NetServer::CreateChatPacket

---

Short version:
simply the length check