Improve errmsg buffer handling in DataManager::Error#2837
Closed
salix5 wants to merge 1 commit into
Closed
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR aims to improve the error message handling in DataManager::Error by updating the buffer copy mechanism.
- Refactored error message copying from using std::strncat to std::strncpy.
- Added explicit null-termination of the buffer after copying.
Comment on lines
+168
to
+169
| std::strncpy(errmsg, sqlite3_errmsg(pDB), sizeof errmsg - 1); | ||
| errmsg[sizeof errmsg - 1] = 0; |
There was a problem hiding this comment.
[nitpick] Consider using a safer string copy approach such as std::snprintf (if available) or a dedicated safe string copy utility to reduce the risk of truncation issues, even though the manual null-termination is handled on the next line.
Suggested change
| std::strncpy(errmsg, sqlite3_errmsg(pDB), sizeof errmsg - 1); | |
| errmsg[sizeof errmsg - 1] = 0; | |
| std::snprintf(errmsg, sizeof errmsg, "%s", sqlite3_errmsg(pDB)); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.