Add audio support option to SoundManager::RefershBGMDir#2838
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR adds conditional audio support to the SoundManager's BGM directory refresh function by wrapping the code with the YGOPRO_USE_AUDIO preprocessor directives.
- Introduces conditional compilation in SoundManager::RefershBGMDir to include audio functionalities.
- Limits audio-related operations to builds with YGOPRO_USE_AUDIO defined.
Comments suppressed due to low confidence (2)
gframe/sound_manager.cpp:71
- Consider adding a comment explaining the purpose of the conditional compilation block for audio support to improve clarity for future maintainers.
#ifdef YGOPRO_USE_AUDIO
gframe/sound_manager.cpp:85
- [nitpick] It may be beneficial to document or implement a fallback behavior when YGOPRO_USE_AUDIO is not defined, ensuring that the absence of audio support is intentional and clear.
#endif // YGOPRO_USE_AUDIO
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.