Skip to content

use premake 5.0.0-beta7 & drop support for premake below 5.0.0-beta4#2842

Merged
purerosefallen merged 3 commits into
Fluorohydride:masterfrom
mercury233:patch-premake-5-beta7
Jun 18, 2025
Merged

use premake 5.0.0-beta7 & drop support for premake below 5.0.0-beta4#2842
purerosefallen merged 3 commits into
Fluorohydride:masterfrom
mercury233:patch-premake-5-beta7

Conversation

@mercury233

@mercury233 mercury233 commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

https://github.com/premake/premake-core/releases/tag/v5.0.0-beta7

  • Starting from Premake beta7, the Premake binary on macOS is a universal binary and can correctly determine os.hostarch().
  • On macOS, switching back to using a manually downloaded Premake, as the Homebrew version may not provide a universal binary.
  • Premake beta7 has fixed the file extension of generated executables on macOS.
  • Premake versions earlier than beta4 are no longer supported.

@purerosefallen

Copy link
Copy Markdown
Collaborator

did beta7 fix the Rosetta problem?

@mercury233

Copy link
Copy Markdown
Collaborator Author

did beta7 fix the Rosetta problem?

idk whether the homebrew version of premake is universal build.

@purerosefallen

Copy link
Copy Markdown
Collaborator
nanahira@haruka-m1 dl % lipo -archs premake5 
x86_64 arm64
nanahira@haruka-m1 dl % 

IT IS

maybe we have to change our CI a bit

@mercury233

Copy link
Copy Markdown
Collaborator Author

the homebrew version of premake is still beta6, are you sure?

@purerosefallen

Copy link
Copy Markdown
Collaborator

the homebrew version of premake is still beta6, are you sure?

I mean the one downloaded from premake https://github.com/premake/premake-core/releases/tag/v5.0.0-beta7

I don't think we should use the one in homebrew because it's not stable enough, and beta7 is universal being good enough

@purerosefallen

Copy link
Copy Markdown
Collaborator
nanahira@haruka-m1 dl % ./premake5  
ARM64
Type 'premake5 --help' for help
nanahira@haruka-m1 dl % 
nanahira@haruka-m1 dl % cat premake5.lua 
print(os.hostarch())
nanahira@haruka-m1 dl % 

and it solved the Rosetta problem and we can remove the ugly Rosetta check thing

@purerosefallen

Copy link
Copy Markdown
Collaborator

TODO:

  • refa github actions to use premake github release download instead of homebrew
  • remove the Rosetta check thing in premake5.lua

@mercury233 mercury233 marked this pull request as draft June 14, 2025 11:32
@mercury233 mercury233 changed the title use premake 5.0.0-beta7 use premake 5.0.0-beta7 & drop support for premake below 5.0.0-beta4 Jun 14, 2025
@mercury233 mercury233 marked this pull request as ready for review June 14, 2025 13:14
@purerosefallen

purerosefallen commented Jun 15, 2025

Copy link
Copy Markdown
Collaborator

btw what is below

is exactly 5.0.0-beta4 supported? This is the last version that mainstream Linux distro glibc support

@mercury233

Copy link
Copy Markdown
Collaborator Author

is exactly 5.0.0-beta4 supported?

only on linux I guess

@purerosefallen

Copy link
Copy Markdown
Collaborator

is exactly 5.0.0-beta4 supported?

only on linux I guess

there are no mac servers, and all build process are automated so version breaking isn't a thing.
However on servers it would be different, as every premake5 binary should be replaced, while premake5 > beta4 has glibc problems.

btw this PR builds fine on the server with premake5 beta4

@purerosefallen

Copy link
Copy Markdown
Collaborator

anything left?

@mercury233

Copy link
Copy Markdown
Collaborator Author

anything left?

If the PR is not a draft, you should assume it is ready to be merged, or that the only remaining thing is for you to click "Merge"

@purerosefallen purerosefallen merged commit e3d08ae into Fluorohydride:master Jun 18, 2025
8 checks passed
@mercury233 mercury233 deleted the patch-premake-5-beta7 branch June 18, 2025 08:58
@purerosefallen

Copy link
Copy Markdown
Collaborator

anything left?

If the PR is not a draft, you should assume it is ready to be merged, or that the only remaining thing is for you to click "Merge"

I clicked appvove long ago.
If you're the last person to approve, and not waiting for other's result, then you click it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants