Remove ocgcore/common.h includes from multiple files#2843
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR removes the inclusion of the ocgcore common header from several files to reduce dependency coupling.
- Removed unnecessary common.h includes from event_handler.cpp, drawing.cpp, and client_field.cpp
- Simplifies header dependencies in the gframe module
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gframe/event_handler.cpp | Removed the inclusion of "../ocgcore/common.h" |
| gframe/drawing.cpp | Removed the inclusion of "../ocgcore/common.h" |
| gframe/client_field.cpp | Removed the inclusion of "../ocgcore/common.h" |
Comments suppressed due to low confidence (3)
gframe/event_handler.cpp:13
- Verify that the removal of this include does not break any dependencies. If types or functions previously provided by common.h are still in use, include the necessary headers or provide forward declarations.
#include "../ocgcore/common.h"
gframe/drawing.cpp:7
- Ensure that removing this include has been compensated with the appropriate header or declaration if functionalities from common.h are required in this file.
#include "../ocgcore/common.h"
gframe/client_field.cpp:8
- Confirm that all necessary dependencies are still available after removal. If any definitions from common.h are still being used, add specific includes or forward declarations as needed.
#include "../ocgcore/common.h"
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.