Skip to content

Remove ocgcore/common.h includes from multiple files#2843

Merged
salix5 merged 2 commits into
Fluorohydride:masterfrom
salix5:patch31
Jun 14, 2025
Merged

Remove ocgcore/common.h includes from multiple files#2843
salix5 merged 2 commits into
Fluorohydride:masterfrom
salix5:patch31

Conversation

@salix5

@salix5 salix5 commented Jun 14, 2025

Copy link
Copy Markdown
Collaborator

No description provided.

@salix5 salix5 requested a review from Copilot June 14, 2025 08:50

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the inclusion of the ocgcore common header from several files to reduce dependency coupling.

  • Removed unnecessary common.h includes from event_handler.cpp, drawing.cpp, and client_field.cpp
  • Simplifies header dependencies in the gframe module

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
gframe/event_handler.cpp Removed the inclusion of "../ocgcore/common.h"
gframe/drawing.cpp Removed the inclusion of "../ocgcore/common.h"
gframe/client_field.cpp Removed the inclusion of "../ocgcore/common.h"
Comments suppressed due to low confidence (3)

gframe/event_handler.cpp:13

  • Verify that the removal of this include does not break any dependencies. If types or functions previously provided by common.h are still in use, include the necessary headers or provide forward declarations.
#include "../ocgcore/common.h"

gframe/drawing.cpp:7

  • Ensure that removing this include has been compensated with the appropriate header or declaration if functionalities from common.h are required in this file.
#include "../ocgcore/common.h"

gframe/client_field.cpp:8

  • Confirm that all necessary dependencies are still available after removal. If any definitions from common.h are still being used, add specific includes or forward declarations as needed.
#include "../ocgcore/common.h"

@salix5 salix5 merged commit c7b674d into Fluorohydride:master Jun 14, 2025
8 checks passed
@salix5 salix5 deleted the patch31 branch June 14, 2025 09:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants