read ExtendedReplayHeader#2847
Closed
salix5 wants to merge 2 commits into
Closed
Conversation
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR updates the replay file reader to fully re-read the header when encountering the REPLAY_ID_YRP2 format, rather than only reading the seed sequence.
- Add conditional rewind and full-header read for YRP2 replays
- Retain existing compressed-stream handling
Comments suppressed due to low confidence (1)
gframe/replay.cpp:127
- [nitpick] Add a brief comment explaining why we must rewind and re-read the entire header for
REPLAY_ID_YRP2, so that readers understand the format differences and special handling.
if (pheader.base.id == REPLAY_ID_YRP2) {
Collaborator
Author
|
I think it would work but can be improved. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.