Skip to content

remove obsoleted cmake support#3100

Merged
mercury233 merged 2 commits into
Fluorohydride:masterfrom
mercury233:patch-cmake-bye
May 31, 2026
Merged

remove obsoleted cmake support#3100
mercury233 merged 2 commits into
Fluorohydride:masterfrom
mercury233:patch-cmake-bye

Conversation

@mercury233

Copy link
Copy Markdown
Collaborator

The CMake support has not been updated for six years and has long since become unusable.

It appears that none of the active project maintainers intend to maintain the CMake support.

Keeping the CMake files only confuses new developers and AI tools.

I actually did some testing to update the CMake support, but I was not successful.

@salix5 salix5 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest that adding a branch for cmake backup

@purerosefallen

Copy link
Copy Markdown
Collaborator

I suggest that adding a branch for cmake backup

a backup for a broken thing?

/* Define to 1 if you have the `geteuid' function. */
/* #undef EVENT__HAVE_GETEUID */

/* TODO: Check for different gethostname argument counts. CheckPrototypeDefinition.cmake can be used. */

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what is this for? related to cmake?

@salix5

salix5 commented May 30, 2026

Copy link
Copy Markdown
Collaborator

I suggest that adding a branch for cmake backup

a backup for a broken thing?

For future developers, if there is one.

@mercury233

Copy link
Copy Markdown
Collaborator Author

I suggest that adding a branch for cmake backup

https://github.com/Fluorohydride/ygopro/tree/cmake-outdated

@mercury233 mercury233 merged commit 75473c3 into Fluorohydride:master May 31, 2026
15 checks passed
@mercury233 mercury233 deleted the patch-cmake-bye branch May 31, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants