Skip to content

minor fixes#3102

Merged
mercury233 merged 4 commits into
Fluorohydride:masterfrom
mercury233:patch-1
Jun 2, 2026
Merged

minor fixes#3102
mercury233 merged 4 commits into
Fluorohydride:masterfrom
mercury233:patch-1

Conversation

@mercury233

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Minor cleanups across three files: refactoring extension checks to use the existing IsExtension helper, replacing a magic number with a named constant, reusing already-declared loop-scope variables, and returning a more meaningful exit code on initialization failure.

Changes:

  • gframe.cpp: Replace inline extension-suffix comparisons with ygo::IsExtension, and return EXIT_FAILURE instead of 0 when initialization fails.
  • single_mode.cpp: Reuse the function-scoped player / count variables in the MSG_HINT and MSG_SHUFFLE_HAND cases instead of redeclaring locals.
  • data_manager.cpp: Use SIZE_SETCODE constant instead of literal 10 in the setcode loop.

Reviewed changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
gframe/gframe.cpp Use IsExtension helper for .ydk/.yrp checks; return EXIT_FAILURE on init failure.
gframe/single_mode.cpp Reuse outer-scope player/count variables in MSG_HINT and MSG_SHUFFLE_HAND.
gframe/data_manager.cpp Replace magic number 10 with SIZE_SETCODE in FormatSetName.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mercury233 mercury233 merged commit f086b6e into Fluorohydride:master Jun 2, 2026
15 checks passed
@mercury233 mercury233 deleted the patch-1 branch June 2, 2026 01:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants