minor fixes#3102
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Minor cleanups across three files: refactoring extension checks to use the existing IsExtension helper, replacing a magic number with a named constant, reusing already-declared loop-scope variables, and returning a more meaningful exit code on initialization failure.
Changes:
gframe.cpp: Replace inline extension-suffix comparisons withygo::IsExtension, and returnEXIT_FAILUREinstead of0when initialization fails.single_mode.cpp: Reuse the function-scopedplayer/countvariables in theMSG_HINTandMSG_SHUFFLE_HANDcases instead of redeclaring locals.data_manager.cpp: UseSIZE_SETCODEconstant instead of literal10in the setcode loop.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gframe/gframe.cpp | Use IsExtension helper for .ydk/.yrp checks; return EXIT_FAILURE on init failure. |
| gframe/single_mode.cpp | Reuse outer-scope player/count variables in MSG_HINT and MSG_SHUFFLE_HAND. |
| gframe/data_manager.cpp | Replace magic number 10 with SIZE_SETCODE in FormatSetName. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.