fix parsing join host#3103
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the LAN “Join Host” flow to improve how the host input is parsed/resolved when connecting as a client.
Changes:
- Refactors join host/port parsing to use separate
hoststr/portstrbuffers and UTF-8 encoding intohostname/port. - Attempts direct IPv4 parsing first, then falls back to DNS resolution via
evutil_getaddrinfowhen needed. - Persists the last-joined host from the host input buffer.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| BufferIO::EncodeUTF8(portstr, port); | ||
| unsigned int remote_addr = htonl(inet_addr(hostname)); | ||
| if(remote_addr == INADDR_NONE) { | ||
| evutil_addrinfo hints{}; |
Collaborator
Author
There was a problem hiding this comment.
i guess not necessary
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.