Skip to content

Prevent opening hand result changes before duel start#3117

Merged
mercury233 merged 2 commits into
masterfrom
patch-rps
Jun 21, 2026
Merged

Prevent opening hand result changes before duel start#3117
mercury233 merged 2 commits into
masterfrom
patch-rps

Conversation

@purerosefallen

Copy link
Copy Markdown
Collaborator

Summary

  • Reject 0 as an invalid opening hand result.
  • Ignore repeated opening hand result packets once a side has already submitted.
  • Use the tag duel team bit to resolve which side's hand result is being submitted.

Notes

This keeps the opening rock-paper-scissors result stable after the first valid submission, while still allowing a new submission round after a draw resets the stored results.

@purerosefallen purerosefallen requested a review from salix5 June 19, 2026 23:37
salix5
salix5 previously requested changes Jun 20, 2026
Comment thread gframe/single_duel.cpp Outdated
Comment thread gframe/tag_duel.cpp
@salix5 salix5 dismissed their stale review June 20, 2026 10:10

Not changing here

@mercury233 mercury233 merged commit dfd5f48 into master Jun 21, 2026
15 checks passed
@mercury233 mercury233 deleted the patch-rps branch June 21, 2026 05:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants