fix tag duel init#3134
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes initialization issues in the Tag Duel mode by moving member initialization into in-class initializers and defaulting special member functions, ensuring deterministic startup state. It also applies the same cleanup style to Single Duel and removes redundant inline specifiers on out-of-line method definitions.
Changes:
- Initialize TagDuel’s pointer/flag/counter/time-tracking members via in-class initializers and default the ctor/dtor.
- Default
SingleDuel’s destructor (no-op) for consistency/clarity. - Remove redundant
inlinefromWriteUpdateDatadefinitions in.cppfiles.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| gframe/tag_duel.h | Adds in-class member initialization to ensure TagDuel starts from a well-defined state. |
| gframe/tag_duel.cpp | Replaces manual constructor initialization with = default and removes redundant inline on an out-of-line definition. |
| gframe/single_duel.h | Whitespace-only cleanup at file end. |
| gframe/single_duel.cpp | Defaults a trivial destructor and removes redundant inline on an out-of-line definition. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.