Skip to content

fix tag duel init#3134

Merged
mercury233 merged 3 commits into
Fluorohydride:masterfrom
mercury233:patch-tag-init
Jul 7, 2026
Merged

fix tag duel init#3134
mercury233 merged 3 commits into
Fluorohydride:masterfrom
mercury233:patch-tag-init

Conversation

@mercury233

Copy link
Copy Markdown
Collaborator

No description provided.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR fixes initialization issues in the Tag Duel mode by moving member initialization into in-class initializers and defaulting special member functions, ensuring deterministic startup state. It also applies the same cleanup style to Single Duel and removes redundant inline specifiers on out-of-line method definitions.

Changes:

  • Initialize TagDuel’s pointer/flag/counter/time-tracking members via in-class initializers and default the ctor/dtor.
  • Default SingleDuel’s destructor (no-op) for consistency/clarity.
  • Remove redundant inline from WriteUpdateData definitions in .cpp files.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
gframe/tag_duel.h Adds in-class member initialization to ensure TagDuel starts from a well-defined state.
gframe/tag_duel.cpp Replaces manual constructor initialization with = default and removes redundant inline on an out-of-line definition.
gframe/single_duel.h Whitespace-only cleanup at file end.
gframe/single_duel.cpp Defaults a trivial destructor and removes redundant inline on an out-of-line definition.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@mercury233 mercury233 merged commit 1d5038b into Fluorohydride:master Jul 7, 2026
16 checks passed
@mercury233 mercury233 deleted the patch-tag-init branch July 7, 2026 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants