fix start_lp=1 in tag duel#3137
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes LP bar rendering in Tag Duel when start_lp is set to 1, preventing maxLP from becoming 0 (and avoiding divide-by-zero / invalid modulo behavior) while keeping the existing “Tag uses half of start LP” display logic.
Changes:
- Add
<algorithm>include to supportstd::max. - Only draw the LP bar when
start_lp > 0(instead of any non-zero value). - Clamp Tag Duel
maxLPto at least1to avoidstart_lp / 2becoming0.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
was setting
maxLPto 0 ifstart_lpis 1should we use
(start_lp + 1) / 2?