fix clicking LISTBOX_LOG#3138
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adjusts the LISTBOX_LOG click handling in ClientField::OnCommonEvent to prevent out-of-bounds access when the selected index equals the log parameter vector size, and aims to make the guard condition clearer.
Changes:
- Fix off-by-one bounds check for
logParamindexing (size() == selshould be treated as out-of-bounds). - Tighten/clarify selection validity checks before opening card info / switching info tabs.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| case LISTBOX_LOG: { | ||
| int sel = mainGame->lstLog->getSelected(); | ||
| if(sel != -1 && (int)mainGame->logParam.size() >= sel && mainGame->logParam[sel]) { | ||
| if(sel >= 0 && (int)mainGame->logParam.size() > sel && mainGame->logParam[sel] > 0) { |
| case LISTBOX_LOG: { | ||
| int sel = mainGame->lstLog->getSelected(); | ||
| if(sel != -1 && (int)mainGame->logParam.size() >= sel && mainGame->logParam[sel]) { | ||
| if(sel >= 0 && (int)mainGame->logParam.size() > sel && mainGame->logParam[sel] > 0) { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
size() == selmean out of bounds