define _WIN32_WINNT#3140
Open
mercury233 wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the Windows build configuration in premake5.lua to define both WINVER and _WIN32_WINNT, ensuring consistent minimum Windows version targeting during compilation.
Changes:
- Define
_WIN32_WINNT=0x0601alongside existingWINVER=0x0601under the Windows Premake filter. - Add an explanatory comment indicating the intent to target Windows 7+ and noting the Windows 10 SDK 1803+ build requirement.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
|
Is it conflicting with #3099 ? |
Collaborator
Author
??? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both
WINVERand_WIN32_WINNTshould be defined.