[SuperEditor] Remove the usage of ScrollbarWithCustomPhysics (Resolves #2561)#2562
Open
angelosilvestre wants to merge 3 commits into
Open
[SuperEditor] Remove the usage of ScrollbarWithCustomPhysics (Resolves #2561)#2562angelosilvestre wants to merge 3 commits into
angelosilvestre wants to merge 3 commits into
Conversation
Contributor
matthew-carroll
left a comment
matthew-carroll
left a comment
There was a problem hiding this comment.
LGTM - Let's get test robots updated and released first, then we can finalize this PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SuperEditor] Remove the usage of ScrollbarWithCustomPhysics (Resolves #2561)
In https://github.com/superlistapp/super_editor/pull/1649, we introduced
ScrollbarWithCustomPhysics, to allow the use of a customScrollPhysicsbecause, at the time, we handled the scrolling ourselves.We don't need to use
ScrollbarWithCustomPhysicsinSuperEditoranymore, because we no longer handle scrolling manually. Thus, we don't need custom physics.This PR removes the usage of
ScrollbarWithCustomPhysicsinSuperEditor. However, we still handle the scrolling inSuperTextField, soScrollbarWithCustomPhysicsis still used there.This PR also use a new extension method from a
flutter_test_robotsPR to make it easier writing tests that interact with the scrollbar.Before landing this PR, we need to release a new version of
flutter_test_robotsand remove the dependency override.