[super_text_layout] Add configurable strut style to SuperText#3009
Open
larryisthere wants to merge 1 commit into
Open
[super_text_layout] Add configurable strut style to SuperText#3009larryisthere wants to merge 1 commit into
larryisthere wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SuperText.strutStyleparameter.SuperTextStrutStyleso an editor or text surface can provide a subtree-wide strut style without threading the value through everySuperTextcall site.LayoutAwareRichTextto the underlyingRenderParagraph.Context
In a SuperEditor-based writing app, I needed stable line metrics while composing text with platform font fallback, especially in CJK/Latin mixed text. Exposing strut configuration at the
SuperTextlayer lets clients opt in to a consistent line-height baseline without forkingsuper_text_layout.Tests
flutter testinsuper_text_layoutflutter analyzeinsuper_text_layout