On Stable before IME breaking change - [SuperEditor] - Update ime integration to work with custom selection types, and add AttachmentListNode as proof of concept#3020
Draft
matthew-carroll wants to merge 2 commits into
Conversation
…add new tests for editable non-text nodes, like a list of attachments WIP: Attachment list node IME support Added attachment list node and component as forcing function for generic IME and layout for flowable content Implemented AttachmentListNode with IME support, arrow key movement, and splitting, combining and deleting Removed print statements Fixed typo in type comparison that broke a bunch of tests Fixed all tests Fixed compilation issue after Flutter upgrade
matthew-carroll
added
ai-review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[SuperEditor] - Update ime integration to work with custom selection types, and add AttachmentListNode as proof of concept