[Super Editor][Super Text Layout] - Fix lost ticker in BlinkController (Resolves #3050)#3051
Merged
matthew-carroll merged 1 commit intoJun 12, 2026
Conversation
matthew-carroll
deleted the
3050_dont-lose-ticker-in-desktop-caret-overlay
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
[Super Editor][Super Text Layout] - Fix lost ticker in BlinkController (Resolves #3050)
In
super_text_layoutin theBlinkControllerwe were null'ing out theTickerwhen we stop blinking, but we shouldn't do that, because then we never recreate it. Now, we stop theTicker, but we don't dispose it or null it out until the controller is disposed.Also, in
super_editor, in theCaretDocumentOverlay, we weren't handling widget changes from ticker to timer, or timer to ticker. This PR adds that support.