-
-
Couldn't load subscription status.
- Fork 615
add step! #1833
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
FelixBenning
wants to merge
12
commits into
FluxML:master
Choose a base branch
from
FelixBenning:training_step
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
add step! #1833
Changes from 1 commit
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
2fa1c7c
add step!
FelixBenning c8f147b
add NEWS.md
FelixBenning 1f34fd7
use withgradient instead
FelixBenning 0765010
apply suggested changes to docstring
FelixBenning 5b4fc17
apply suggested changes to docstring
FelixBenning 12a8284
rename step! to optimstep!
FelixBenning 68a0590
add optimstep! to docs
FelixBenning c321e4f
update optimisers section
FelixBenning bb7b5c5
apostrophes
FelixBenning cc31acb
bracket at the end of the sentence
FelixBenning 5220fe9
Update NEWS.md
FelixBenning fa68993
Update src/optimise/Optimise.jl
FelixBenning File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest
optimstep!instead oftrainstep!to indicate that this is the optimiser interface and keep the ML jargon to a minimumUh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One vote for something evoking
train!to stress that they are closely related.If the longer-term plan is to use Optimisers.jl, this may not fit with
train!at all -- some recent discussion here: #1902 (comment) . In which case there will be an implicit-styletrain!&Paramsstory, and an explicit-stylegradientandOptimisers.update!. With such a divide, this function wants to be clearly on thetrain!&Paramsside.Maybe it should just be 3-arg
train!? Without a data iterator, there is no iteration, that's all: