Mark dropout_mask as non-differentiable#1870
Merged
Conversation
mcabbott
approved these changes
Feb 13, 2022
ToucheSir
commented
Feb 13, 2022
Member
Author
ToucheSir
left a comment
ToucheSir
left a comment
There was a problem hiding this comment.
Need to fix a test and add news, a couple comments while I do:
ToucheSir
force-pushed
the
bc/nondiff_dropout_mask
branch
from
e0f6c9d to
deea76a
Compare
Codecov Report
@@ Coverage Diff @@
## master #1870 +/- ##
=======================================
Coverage 84.58% 84.58%
=======================================
Files 21 21
Lines 1486 1486
=======================================
Hits 1257 1257
Misses 229 229
Continue to review full report at Codecov.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Should allow for nested AD of Dropout.
PR Checklist
- [ ] Documentation, if applicable