Conversation
Codecov ReportBase: 86.26% // Head: 86.20% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #2066 +/- ##
==========================================
- Coverage 86.26% 86.20% -0.06%
==========================================
Files 18 18
Lines 1361 1363 +2
==========================================
+ Hits 1174 1175 +1
- Misses 187 188 +1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
I think it might be confusing for users. Someone used to Is it possible to make this method more "official" with knobs to turn on/off the details? Then the default |
|
Yes this is my concern too. I wonder a bit how useful these things really are, how often do people get NaN? Maybe typically through the loss becoming infinite etc? Can we pre-compile GPU stuff? It just seems a little crazy to wait 20s for the printing code to warm up... |
We could definitely try using SnoopPrecompile. Based on JuliaLang/julia#46296 and JuliaLang/julia#46373 though, that may have to wait until the next 1.7 and 1.8 point releases. |
The present
showmethods have about a 20s startup delay when the model is on the GPU. This comes from the checks likeany(isnan, x)which print friendly warnings. Perhaps we should remove them, to save startup time?This PR replaces them with an "(on GPU)" annotation, like so:
Maybe that ends up quite noisy for bigger models. For this reason I didn't make it some bright colour.