Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2574 +/- ##
=======================================
Coverage 32.50% 32.50%
=======================================
Files 34 34
Lines 2003 2003
=======================================
Hits 651 651
Misses 1352 1352 ☔ View full report in Codecov by Sentry. |
|
CI seems to get NNlib has errors FluxML/NNlib.jl#619 |
|
It's because of ComponentArrays used in tests. It needs a bump for UPD: Ah and optimisers as well. |
|
Ok, we are now picking Zygote 0.7.1 but there are some real failures |
|
I think conv failures should be fixed by FluxML/NNlib.jl#620 |
|
Now tests are not passing due to julia> m = Chain([Dense(3 => 4, tanh; bias=false), Dense(4 => 2)]);
julia> x = randn(Float32,3,5);
julia> y = rand(Bool,2,5);
julia> g = gradient(m -> Flux.logitcrossentropy(m(x), y), m)[1]
(layers = NamedTuple{(:weight, :bias, :σ)}[(weight = InplaceableThunk(ChainRules.var"#..., Thunk(ChainRules.var"#...)), bias = nothing, σ = nothing), (weight = Thunk(Zygote.var"#...), bias = Float32[-0.088241935, 0.088241935], σ = nothing)],) |
|
Maybe |
|
I wouldn't expect any thunk to appear in the output of Zygote.gradient as well, right? |
|
Reduced to julia> using Flux
julia> layers = [Dense(3, 4)]
1-element Vector{Dense{typeof(identity), Matrix{Float32}, Vector{Float32}}}:
Dense(3 => 4) # 16 parameters
julia> x = ones(Float32, 3);
julia> g = gradient(layers -> sum(layers[1](x)), layers)[1]
1-element Vector{@NamedTuple{weight::ChainRulesCore.Thunk{Zygote.var"#163#164"{Nothing, ChainRulesCore.InplaceableThunk{ChainRulesCore.Thunk{ChainRules.var"#551#556"{Vector{Float32}, Vector{Float32}}}, ChainRules.var"#550#555"{Vector{Float32}, Vector{Float32}}}}}, bias::Vector{Float32}, σ::Nothing}}:
(weight = Thunk(Zygote.var"#...), bias = [1.0, 1.0, 1.0, 1.0], σ = nothing) |
|
I have a fix, let me see if it breaks anything else. |
|
Should be fixed by FluxML/Zygote.jl#1551 |
|
Should be good. Other errors are unrelated |
PR Checklist