Open
Conversation
Author
|
Marking as draft until the MLDataDevices PR is merged |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2635 +/- ##
===========================================
+ Coverage 32.09% 65.93% +33.84%
===========================================
Files 32 33 +1
Lines 2038 2087 +49
===========================================
+ Hits 654 1376 +722
+ Misses 1384 711 -673 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Author
|
@CarloLucibello Should I bump the minimum required version of MLDataDevices as well? |
Member
yes. Can we add some tests, e.g. for Dense forward and backward passes? |
Author
|
@CarloLucibello will these be good enough? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
imports and re-exports OpenCL from MLDataDevices, for usage in Flux.jl
Depends on LuxDL/Lux.jl#1590