-
-
Notifications
You must be signed in to change notification settings - Fork 37
support finding dependencies of a variable #63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Roger-luo
wants to merge
12
commits into
FluxML:master
Choose a base branch
from
Roger-luo:find_dependencies
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
279f2de
find dependencies
Roger-luo ec2d05e
Merge branch 'master' into find_dependencies
Roger-luo 82acdb9
rework dependencies
Roger-luo f976ed5
let usage pass for other things
Roger-luo 700cbed
rm info test
Roger-luo 527527e
add broken
Roger-luo e621060
comment out a test
Roger-luo a091c78
rework dependencies
Roger-luo 84296ef
Merge branch 'master' into find_dependencies
Roger-luo 5cb1486
fix test
Roger-luo 1f877a7
fix test
Roger-luo 6da6db8
fix unconditional br
Roger-luo File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,5 +1,5 @@ | ||
| using IRTools, Test | ||
| using IRTools: CFG, dominators, domtree | ||
| using IRTools: CFG, dominators, domtree, dependencies, find_dependency_path, var | ||
|
|
||
| relu(x) = (y = x > 0 ? x : 0) | ||
| ir = @code_ir relu(1) | ||
|
|
@@ -10,3 +10,48 @@ ir = @code_ir relu(1) | |
| @test domtree(CFG(ir)) == (1 => [2 => [], 3 => [], 4 => []]) | ||
|
|
||
| @test domtree(CFG(ir)', entry = 4) == (4 => [1 => [], 2 => [], 3 => []]) | ||
|
|
||
| function f(x) | ||
| x = sin(x) | ||
| y = cos(x) | ||
|
|
||
| if x > 1 | ||
| x = cos(x) + 1 | ||
| else | ||
| x = y + 1 | ||
| end | ||
| return x | ||
| end | ||
|
|
||
| ir = @code_ir f(1.0) | ||
|
|
||
| @test dependencies(ir) == Dict( | ||
| var(9) => Set([var(8), var(7)]), | ||
| var(8) => Set([var(4)]), | ||
| var(7) => Set([var(6)]), | ||
| var(3) => Set([var(2)]), | ||
| var(5) => Set([var(3)]), | ||
| var(6) => Set([var(3)]), | ||
| var(4) => Set([var(3)]), | ||
| ) | ||
|
|
||
| @test find_dependency_path(ir, var(9)) == Set(var.([2, 8, 7, 3, 4, 6])) | ||
|
|
||
| # function f(x) | ||
| # x = sin(x) | ||
| # y = cos(x) | ||
|
|
||
| # @info "warning" x | ||
|
|
||
| # if x > 1 | ||
| # x = cos(x) + 1 | ||
| # else | ||
| # x = y + 1 | ||
| # end | ||
| # return x | ||
| # end | ||
|
|
||
| # ir = @code_ir f(1.0) | ||
|
|
||
| # # NOTE: this test is broken due to different IR generated by 1.0 and 1.2+ | ||
| # @test_broken find_dependency_path(ir, var(48)) == Set(var.([47, 46, 42, 45, 41, 3, 4, 2])) | ||
|
||
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For
Expryou could just iterate over the arguments, rather than the heavierprewalk.