provides ways to circumvent unexpected type bindings#160
Open
aviatesk wants to merge 1 commit intoFluxML:masterfrom
Open
provides ways to circumvent unexpected type bindings#160aviatesk wants to merge 1 commit intoFluxML:masterfrom
aviatesk wants to merge 1 commit intoFluxML:masterfrom
Conversation
Contributor
Author
|
@MikeInnes can you please review this PR ? I really need these changes to make my package work, which makes a heavy use of |
This PR fixes issues involved with the syntaxes to specify expression types. Currently, `@capture` and `@match` can't distinguish between their syntax to specify a `:head` of `Expr` and a variable name with underscores. For example, in the example below, `@capture` recognizes `global_string` as the syntax to specify `Expr`'s head (i.e. `:string`), not as a simple variable name: ```julia julia> ex = :(global_string = 10); julia> @capture(ex, global_string = n_) # tries to match `Expr(:string, ...) = n_` and bound the matched lhs into a variable `global` and the matched rhs into a variable `n`. false ``` Since an expression can really have an arbitrary head, `@capture` macro can't really distinguish them (while we can do some assertion when the syntax to specify atomic expression type, though). This PR implements new macros `@capture_notb` and `@match_notb`, which ignore all the expression type matching syntaxes and provide the ways to circumvent the issue described above: ```julia julia> ex = :(global_string = 10) julia> @capture_notb(ex, global_string = n_) # tries to match `global_string = n_` pattern and bound the matched rhs into a variable `n`. true ``` These changes aren't breaking but they're somewhat a big change, I'd like to minor version bump.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR fixes issues involved with the syntaxes to specify expression types.
Currently,
@captureand@matchcan't distinguish between their syntaxto specify a
:headofExprand a variable name with underscores.For example, in the example below,
@capturerecognizesglobal_stringas the syntax to specify
Expr's head (i.e.:string), not as a simplevariable name:
Since an expression can really have an arbitrary head,
@capturemacrocan't really distinguish them (while we can do some assertion when the
syntax to specify atomic expression type, though).
This PR implements new macros
@capture_notband@match_notb, whichignore all the expression type matching syntaxes and provide the ways to
circumvent the issue described above:
These changes aren't breaking but they're somewhat a big change, I'd
like to minor version bump.