Expose a uniform API at the highest level for models#190
Merged
darsnack merged 9 commits intoFluxML:masterfrom Aug 3, 2022
theabhirath:refine
Merged
Expose a uniform API at the highest level for models#190darsnack merged 9 commits intoFluxML:masterfrom theabhirath:refine
darsnack merged 9 commits intoFluxML:masterfrom
theabhirath:refine
Conversation
Also a. more type annotations b. Expose only configurations vital to the model API in terms of pretraining at the highest level
Also a. more type annotations b. Expose only configurations vital to the model API in terms of pretraining at the highest level
Member
Author
|
Pending CI, this should be good to go! |
darsnack
approved these changes
Aug 3, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR does a bunch of stuff:
inchannelsandnclassesas uniform options for all models, helping along Addinchannels,imsize,nclassesas kwargs for all constructors #176 - onlyimsizeis left now.invertedresidualas prep for an EfficientNetv2 PR that will be landing shortly.create_classifierin most cases where it can be for brevity