Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use julia-actions/cache in CI #260

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Conversation

IanButterworth
Copy link
Contributor

Just a fly-by suggestion while creating #259

julia-actions/cache is now more powerful and stores precompile caches

PR Checklist

  • Tests are added
  • Documentation, if applicable

Copy link
Member

@ToucheSir ToucheSir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice to see it working now. How might we observe the performance improvements from caching? Also, is there an equivalent for Buildkite (to help solve our current timeout issues)?

@ToucheSir ToucheSir merged commit de4f684 into FluxML:master Dec 5, 2023
@IanButterworth IanButterworth deleted the ib/cache branch December 5, 2023 15:39
@IanButterworth
Copy link
Contributor Author

If you can, I recommend moving to the standard julia-actions/julia-runtest because it sets up coverage in a faster way and does parallel precompilation. The current setup here is hitting old serial precompilation (which is silently happening at the start of the test run)

@IanButterworth
Copy link
Contributor Author

Multiplexing test groups via an env var that's handled in runtests.jl should be doable?

@ToucheSir
Copy link
Member

ToucheSir commented Dec 5, 2023

Another problem:
image
Trying to normalize these suite names would be more yaml-foo than I want to deal with right now (because we still need them for ReTest to work properly). Come to think of it, this is probably why we don't use an env var too. Is there no way to make have the cache action work with them, given that they are still valid paths on *nix systems?

@IanButterworth
Copy link
Contributor Author

That should be fixed upstream in the cache action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants