Adding support for And

[dstarkenburg]

Adding support for the And layer of the ONNX

PR Checklist

• Tests are added
• Documentation, if applicable

[dfdx]

It looks like Bool still doesn't work on Julia 1.6. Do you have an idea how to fix it or should we consider bumping the minimal version to 1.9?

[dstarkenburg]

It looks like Bool still doesn't work on Julia 1.6. Do you have an idea how to fix it or should we consider bumping the minimal version to 1.9?

Im thinking it might have to do with the fact that ONNXRunTime 0.3.0 also doesnt have a Bool datatype which makes me think, unless we can patch an earlier version of ONNXRunTime for 1.6 (Long term support is pretty important) then we might be out of luck.

[dfdx]

earlier version of ONNXRunTime for 1.6 (Long term support is pretty important)

But the current LTS version is 1.10, no?
I think we can drop 1.6 in favor of 1.10 and dump minor version of the package. This way users on Julia < 1.10 will still be able to use older version of ONNX.jl.

[dstarkenburg]

earlier version of ONNXRunTime for 1.6 (Long term support is pretty important)

But the current LTS version is 1.10, no? I think we can drop 1.6 in favor of 1.10 and dump minor version of the package. This way users on Julia < 1.10 will still be able to use older version of ONNX.jl.

Huh! look at that. I like it; what steps need to be done to bump minimal version.

[dfdx]

You need to change two lines of code in Project.toml:

1. julia = "1.6" -> julia = 1.10 - this way the new version of the package will not be installable on Julia < 1.10.
2. version = "0.2.7" -> version = "0.3.0" - this way all packages that fixed ONNX.jl version to 0.2.x will not get updated.

It may be sufficient to only change the first line, but I'd still update the ONNX.jl version as well to indicate that something important happened to the package.

I'd also change test matrix in the Github job from this:

        version:
          - '1.6'
          - '1.9'

to this:

        version:
          - '1.10'
          - '1'

1.10 means that tests will run on the LTS version (latest of 1.10.x) and 1 means that tests will run on the latest released version (1.x.x).

[dfdx]

I see the changes in Project.toml, thanks! If you could also update Test.yml as described above, we would immediately see its effect on CI/CD. Alternatively, we can merge this PR, and I will update the Github script by myself.

[dstarkenburg]

Let me know if I did the new Umlaut compat correctly. I see that umlaut 0.7 is needed for 1.10 onward. But, did I not need to remove all the prior versions in the Project.toml not for the tests?

[dfdx]

Umlaut 0.7 fixes names of some internal Julia objects introduced in recent versions of the language, so using it on Julia 1.10+ is totally justified.

The PR looks good to me. Thanks!