Skip to content

test: new reactant opt breaks test #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
CarloLucibello merged 1 commit into from
Dec 11, 2025
Merged

test: new reactant opt breaks test #220

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions test/reactant.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,24 +14,24 @@ using Reactant, Optimisers

@testset "out of place" begin
hlo = @code_hlo Optimisers.update(st_opt, x_ra, gs_ra)
@test length(findall("dense<1.100000e-02>", repr(hlo))) == 2
@test length(findall("1.100000e-02>", repr(hlo))) == 2

st_opt2, x_ra2 = @jit Optimisers.update(st_opt, x_ra, gs_ra)

hlo = @code_hlo Optimisers.update(st_opt_ra, x_ra, gs_ra)
@test !contains(repr(hlo), "dense<1.100000e-02>")
@test !contains(repr(hlo), "1.100000e-02>")

st_opt2_ra, x_ra2 = @jit Optimisers.update(st_opt_ra, x_ra, gs_ra)
end

@testset "in place" begin
hlo = @code_hlo Optimisers.update!(st_opt, x_ra, gs_ra)
@test length(findall("dense<1.100000e-02>", repr(hlo))) == 2
@test length(findall("1.100000e-02>", repr(hlo))) == 2

st_opt2, x_ra2 = @jit Optimisers.update!(st_opt, x_ra, gs_ra)

hlo = @code_hlo Optimisers.update!(st_opt_ra, x_ra, gs_ra)
@test !contains(repr(hlo), "dense<1.100000e-02>")
@test !contains(repr(hlo), "1.100000e-02>")

st_opt2_ra, x_ra2 = @jit Optimisers.update!(st_opt_ra, x_ra, gs_ra)
end
Expand Down
Loading