Conversation
mcabbott
commented
Jul 3, 2022
Comment on lines
365
to
366
| @adjoint parent(x::LinearAlgebra.Adjoint) = parent(x), ȳ -> (LinearAlgebra.Adjoint(ȳ),) | ||
| @adjoint parent(x::LinearAlgebra.Transpose) = parent(x), ȳ -> (LinearAlgebra.Transpose(ȳ),) |
Member
Author
There was a problem hiding this comment.
I forgot that JuliaDiff/ChainRulesCore.jl#446 isn't merged, so removing these lines probably isn't a good idea.
Before:
julia> gradient(x -> first(parent(x)), [1,2,3]')[1]
1×3 adjoint(::Vector{Float64}) with eltype Float64:
1.0 0.0 0.0
This PR, with tagged CRC:
julia> gradient(x -> first(parent(x)), [1,2,3]')[1]
(parent = [1.0, 0.0, 0.0],)
Member
There was a problem hiding this comment.
One alternative idea is to desguar the @adjoint and overload _pullback directly. That'll have the benefit of removing some unnecessary layers, while making it easier to do stuff like FluxML/ZygoteRules.jl#22.
Member
Author
There was a problem hiding this comment.
Glad to see there were tests for this, at least: fails on isapprox(::NamedTuple{(:parent,), ...}, ::Matrix{Float64}).
Member
Author
|
Ok to merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes #1257