Add missing overloads for Tridiagonal#1362
Open
ChrisRackauckas wants to merge 2 commits intoFluxML:masterfrom
Open
Add missing overloads for Tridiagonal#1362ChrisRackauckas wants to merge 2 commits intoFluxML:masterfrom
ChrisRackauckas wants to merge 2 commits intoFluxML:masterfrom
Conversation
Upstreaming from DiffEqFlux (SciML/DiffEqFlux.jl#800)
Member
|
Are there tests to be upstreamed as well? Seems like this could fix #455 too. |
Member
Author
|
The tests are really just the downstream DiffEqFlux tests. There's no simple test right now that we can upstream here, it's deep in a deep code (comes from SplineLayer which pulls in DataInterpolations etc.). Someone can probably dig in and make a test out of that. |
Member
|
This looks like what JuliaDiff/ChainRulesCore.jl#446 is meant to fix. Can you check easily? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upstreaming from DiffEqFlux (SciML/DiffEqFlux.jl#800)