Draft
Conversation
2 tasks
Member
Author
|
Turns out just changing Zygote's own |
oxinabox
reviewed
May 3, 2023
Co-authored-by: Frames White <oxinabox@ucc.asn.au>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following on #1385, this allows us to propagate
ZeroTangent,NoTangentandNotImplementedinside the boundary ofpullback. Doing so should prevent lossy conversions back and forth, as well as inadvertent dropping of the erroring functionalityNotImplementedbrings. Conversions remain the same for the user-level API, which means this only partially addresses #1227.This PR can be seen as an incremental step towards #603. There are a couple of options for next steps:
Tangents to pass through without conversionrrules.PR Checklist