Merged
Conversation
devmotion
commented
Oct 26, 2023
devmotion
commented
Oct 26, 2023
Member
Author
|
Seems #1328 "fixed" all but one test error. |
oxinabox
approved these changes
Oct 26, 2023
Member
Author
|
Flux test failure indicates that the latest Zygote release fixed a test that is currently marked as broken. Should be fixed by FluxML/Flux.jl#2349. |
Member
Author
|
😅 I implicitly assumed that the ZygoteRules PR had been merged due to existence of ZygoteRules 0.2.4. But it seems this new release just contains the additional downstream tests. So possibly the two other fixes in the PR that I reverted are still needed once the ZygoteRules PR is actually merged an released. |
Member
|
That was my bad, I thought it was merged too and tagged a release! I agree with your idea in #1466 (comment), just need a quick sanity check from someone else before we start merging and updating the Zygote interface too. |
Pangoraw
pushed a commit
to Pangoraw/Zygote.jl
that referenced
this pull request
Dec 4, 2023
* Fix tests for ZygoteRule change * Apply suggestions from code review
Pangoraw
pushed a commit
to Pangoraw/Zygote.jl
that referenced
this pull request
Dec 4, 2023
* Fix tests for ZygoteRule change * Apply suggestions from code review
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes of the tests for FluxML/ZygoteRules.jl#26. See #1466.Fixes a test.