Skip to content

Make @adjoint unthunk pullback inputs #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
DhairyaLGandhi merged 4 commits into from
Sep 22, 2021
Merged

Make @adjoint unthunk pullback inputs #17

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
39201d9
unthunk in adjoint
oschulz May 7, 2021
7c2b910
Add macro djoint_keepthunks
oschulz May 8, 2021
b8b91a2
Map unthunk_tangent over NamedTuples
oschulz May 8, 2021
05cd6e1
Remove macro adjoint_keepthunks
oschulz May 11, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 13 additions & 5 deletions src/adjoint.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,14 @@ function adjoint end
function _pullback end
function pullback end

function gradm(ex, mut = false)

function unthunk_tangent end
@inline unthunk_tangent(x) = x
@inline unthunk_tangent(x::Tuple) = map(unthunk_tangent, x)
@inline unthunk_tangent(x::NamedTuple) = map(unthunk_tangent, x)


function gradm(ex, mut = false, keepthunks = false)
@capture(shortdef(ex), (name_(args__) = body_) |
(name_(args__) where {Ts__} = body_)) || error("Need a function definition")
kw = length(args) > 1 && isexpr(args[1], :parameters) ? esc(popfirst!(args)) : nothing
Expand All @@ -51,28 +58,29 @@ function gradm(ex, mut = false)
gradtuple = isclosure ? gradtuple0 : gradtuple1
gradtuplekw = isclosure ? gradtuple2 : gradtuple3
adj = @q @inline ZygoteRules.adjoint($(fargs...)) where $(Ts...) = $(esc(body))
maybe_unthunked_Δ = keepthunks ? :Δ : :(unthunk_tangent(Δ))
quote
$adj
@inline function ZygoteRules._pullback($cx, $f::$T, $(args...)) where $(Ts...)
y, _back = adjoint(__context__, $f, $(argnames...))
$(mut ? nothing : :(back(::Nothing) = nothing))
back(Δ) = $gradtuple(_back(Δ))
back(Δ) = $gradtuple(_back($maybe_unthunked_Δ))
return y, back
end
@inline function ZygoteRules._pullback($cx, ::$kT, kw, $f::$T, $(args...)) where $(Ts...)
y, _back = adjoint(__context__, $f, $(argnames...); kw...)
$(mut ? nothing : :(back(::Nothing) = nothing))
back(Δ) = $gradtuplekw(_back(Δ))
back(Δ) = $gradtuplekw(_back($maybe_unthunked_Δ))
return y, back
end
nothing
end
end

macro adjoint(ex)
gradm(ex)
gradm(ex, false, false)
end

macro adjoint!(ex)
gradm(ex, true)
gradm(ex, true, false)
end