Skip to content

Pass through ChainRules zeros in @adjoint too #25

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ToucheSir merged 1 commit into from
Mar 21, 2023
Merged

Pass through ChainRules zeros in @adjoint too #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Manifest.toml
21 changes: 0 additions & 21 deletions Manifest.toml
View file
Open in desktop

This file was deleted.

1 change: 1 addition & 0 deletions Project.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ uuid = "700de1a5-db45-46bc-99cf-38207098b444"
version = "0.2.2"

[deps]
ChainRulesCore = "d360d2e6-b24c-11e9-a2a3-2a2ae2dbcce4"
MacroTools = "1914dd2f-81c6-5fcd-8719-6d5c9610ff09"

[compat]
Expand Down
11 changes: 9 additions & 2 deletions src/adjoint.jl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
using MacroTools
using MacroTools: @q, combinedef
using ChainRulesCore: AbstractZero

function named(arg)
if isexpr(arg, :(::)) && length(arg.args) == 1
Expand Down Expand Up @@ -63,13 +64,19 @@ function gradm(ex, mut = false, keepthunks = false)
$adj
@inline function ZygoteRules._pullback($cx, $f::$T, $(args...)) where $(Ts...)
y, _back = adjoint(__context__, $f, $(argnames...))
$(mut ? nothing : :(back(::Nothing) = nothing))
$(mut ? nothing : quote
back(::Nothing) = nothing
back(Δ::AbstractZero) = $gradtuple(ntuple(_ -> Δ, $(length(args))))
end)
back(Δ) = $gradtuple(_back($maybe_unthunked_Δ))
return y, back
end
@inline function ZygoteRules._pullback($cx, ::$kT, kw, $f::$T, $(args...)) where $(Ts...)
y, _back = adjoint(__context__, $f, $(argnames...); kw...)
$(mut ? nothing : :(back(::Nothing) = nothing))
$(mut ? nothing : quote
back(::Nothing) = nothing
back(Δ::AbstractZero) = $gradtuplekw(ntuple(_ -> Δ, $(length(args))))
end)
back(Δ) = $gradtuplekw(_back($maybe_unthunked_Δ))
return y, back
end
Expand Down