Skip to content

Make cancellation after a pause settle every balance component correctly #1554

Description

@Jagadeeshftw

Area: Cancellation / accounting

Problem

Cancellation depends on accrual state, paused duration, and token movement, but the combined paused-then-cancel path needs explicit refund and vested assertions.

Design decision required

Define settlement while paused and whether cancellation itself clears pause metadata before transfer.

Deliverable

Cover cancel before pause, during pause, after resume, and repeated cancel with exact sender/recipient balances.

Acceptance criteria

  • The selected behavior is implemented and covered by focused regression tests.
  • Failure, boundary, retry, and authorization behavior is explicit where applicable.
  • Existing behavior outside this scope remains unchanged.
  • CI output and any performance/resource impact are reported in the PR.

Out of scope

  • Typo-only, documentation-only, unrelated refactors, and dependency churn.
  • Closing, weakening, or skipping tests to make the change pass.

Verification

cargo test -p fluxora-stream cancel -- --nocapture

PR requirements

  • Keep the PR focused, explain the before/after behavior, and reference this issue.
  • Include the requested regression evidence and relevant CI results.
  • Open the PR within 48 hours of assignment or leave a scope question on the issue.
  • Contributor discussion: https://t.me/+u5qmu35nZ7I0OTU1

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave program

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions