ci: fix workspace tests, wasm target, and job graph for Protocol 27 - #1670
Merged
Jagadeeshftw merged 2 commits intoAug 31, 2026
Merged
Conversation
- Replace dtolnay/rust-toolchain@1.94.1 with rustup show so the
pinned toolchain in rust-toolchain.toml (1.97.1, wasm32v1-none)
is used automatically in every job
- Add dedicated 'test' job that runs cargo test --workspace
(covers fluxora-stream + fluxora-archival-probe, no continue-on-error)
- Add dedicated 'build' job that runs
cargo build --workspace --target wasm32v1-none --release
followed by script/release.sh for release-isolation gate
- Fix WASM target: wasm32-unknown-unknown -> wasm32v1-none
(correct for Protocol 23+ / soroban-sdk 27)
- Remove duplicate 'fuzz' job key (YAML silently dropped one)
- Remove continue-on-error from all test and build steps
- Fix deploy job needs: [build, test] -> [lint, test, build]
(previous ids did not exist; deploy jobs could never run)
- Fix coverage job needs: test (id now exists)
- Move build steps (release.sh, sha256, Cargo.lock check) out of
lint and into the build job where they belong
- Record rustc/cargo version to GITHUB_STEP_SUMMARY in every Rust job
- Restrict nightly-fuzz to schedule events only
Artifact name preserved: fluxora_stream.wasm
Both crates covered: fluxora-stream, fluxora-archival-probe
Closes: CI regression gate issue
|
@Moh-dakai Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The existing ci.yml had several structural problems that prevented it from proving either workspace crate compiles or passes tests. This PR fixes every
identified defect without changing any contract code, tests, or build scripts.
What was broken
┌───────────────────────────────────────────────────────────────────┬───────────────────────────────────────────────────────────────────────────────────────┐
│ Problem │ Impact │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ Toolchain hardcoded as dtolnay/rust-toolchain@1.94.1 │ Wrong version; rust-toolchain.toml pins 1.97.1 │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ WASM target wasm32-unknown-unknown │ Emits unsupported features for Protocol 23+ contracts; correct target is │
│ │ wasm32v1-none │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ Duplicate fuzz: job key │ YAML silently discarded one entire job │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ cargo test --all-features (not --workspace) in lint │ fluxora-archival-probe was never tested │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ continue-on-error: true on a test step │ A test regression passed CI silently │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ Build steps (release.sh, sha256, Cargo.lock check) placed in lint │ Wrong job semantics; errors misreported as lint failures │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ Deploy jobs needs: [build, test] — those job IDs didn't exist │ Deploy jobs could never run │
├───────────────────────────────────────────────────────────────────┼───────────────────────────────────────────────────────────────────────────────────────┤
│ coverage job needs: test — that job ID didn't exist │ Coverage never ran │
└───────────────────────────────────────────────────────────────────┴───────────────────────────────────────────────────────────────────────────────────────┘
What changed
clippy) without duplicating it in the workflow.
(release-isolation gate: builds only fluxora-stream, asserts probe wasm is absent). Uploads fluxora_stream.wasm with if-no-files-found: error.
lint/test/build).
Artifact name preserved: fluxora_stream.wasm at target/wasm32v1-none/release/.
Verification
cargo test --workspace # both crates pass
cargo build --workspace --target wasm32v1-none --release # both crates compile
script/release.sh # product-only artifact, probe absent
Scope
No contract code, tests, scripts, or documentation were modified — only .github/workflows/ci.yml..
closes #1529