Fix security vulnerability: Replace node-sass with sass#149
Open
master3395 wants to merge 2 commits intoFlynntes:masterfrom
Open
Fix security vulnerability: Replace node-sass with sass#149master3395 wants to merge 2 commits intoFlynntes:masterfrom
master3395 wants to merge 2 commits intoFlynntes:masterfrom
Conversation
Contributor
master3395
commented
Jan 3, 2026
master3395
commented
- Replace vulnerable node-sass (^4.12.0) with sass (^1.80.0)
- Fixes qs package vulnerabilities (Prototype Pollution and DoS via arrayLimit bypass)
- Update npm scripts to use new sass CLI syntax
- Add build script for production builds
- Resolves security vulnerabilities Bug with backend 2 #47 and Uppercase headings and placeholders using CSS #48
- Replace vulnerable node-sass (^4.12.0) with sass (^1.80.0) - Fixes qs package vulnerabilities (Prototype Pollution and DoS via arrayLimit bypass) - Update npm scripts to use new sass CLI syntax - Add build script for production builds - Resolves security vulnerabilities Flynntes#47 and Flynntes#48
…irect PR Flynntes#48: Uppercase headings and placeholders using CSS - Change HTML placeholders from uppercase to lowercase for better accessibility - Add CSS text-transform: uppercase for headings (.sleeky-heading) - Add CSS text-transform: uppercase for input placeholders (.sleeky-input) - Update SCSS with cross-browser placeholder support - Compile updated styles.css Issue Flynntes#35: Fix blank page after login redirect - Add redirect_location filter to clean admin redirect URLs - Remove trailing ? and .php extensions from redirect URLs - Prevent double slashes in redirect URLs - Fixes blank page issue after successful login Resolves: Flynntes#35, Flynntes#48
Aternus
reviewed
Jan 5, 2026
| HEAD; | ||
| } | ||
|
|
||
| // Fix login redirect URL to prevent blank page after login (Issue #35) |
There was a problem hiding this comment.
Hmm, how about separating this into it's own PR?
Aternus
reviewed
Jan 5, 2026
| text-transform: uppercase; | ||
| } | ||
|
|
||
| // PR #48: Uppercase headings and placeholders using CSS |
There was a problem hiding this comment.
Looks like the same suggestion from above can be applied here
|
@master3395 Looks like there is more content in the PR than what the PR description says, how about updating it to reflect that or separating the content into different PRs? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.