Skip to content

Conversation

@rvbuelow
Copy link

@rvbuelow rvbuelow commented Oct 4, 2025

Tested once, works fine for me.

@rvbuelow rvbuelow mentioned this pull request Oct 4, 2025
@GrylledCheez
Copy link
Collaborator

@rvbuelow, fix the eslint errors except for "Extension defined but not used" and I'll merge it

@rvbuelow
Copy link
Author

rvbuelow commented Oct 4, 2025

Erm ... none of these errors have anything to do with what i changed. Fix it yourself :D

Run npx eslint . --ext .js --ignore-pattern node_modules/

/home/runner/work/wintile/wintile/extension.js
9:7 error 'Extension' is assigned a value but never used. Allowed unused vars must match /(^unused|Manager|fillPreferencesWindow|enable|disable|init|_$)/u no-unused-vars
45:2 error Missing semicolon semi
720:19 error Expected a linebreak before this statement nonblock-statement-body-position
1082:1 error Expected indentation of 4 spaces but found 0 indent
1083:1 error Expected indentation of 4 spaces but found 0 indent
1084:1 error Expected indentation of 4 spaces but found 0 indent
1233:2 error Missing semicolon semi
1236:1 error Missing JSDoc comment jsdoc/require-jsdoc

/home/runner/work/wintile/wintile/keybindings.js
110:2 error Missing semicolon semi

/home/runner/work/wintile/wintile/prefs.js
17:1 error Missing JSDoc comment jsdoc/require-jsdoc
17:10 error 'buildPrefsWidget' is defined but never used. Allowed unused vars must match /(^unused|Manager|fillPreferencesWindow|enable|disable|init|_$)/u no-unused-vars
20:1 error Expected indentation of 4 spaces but found 0 indent
21:1 error Expected indentation of 4 spaces but found 0 indent
22:1 error Expected indentation of 4 spaces but found 0 indent
23:1 error Expected indentation of 4 spaces but found 0 indent
25:1 error Expected indentation of 4 spaces but found 8 indent
27:1 error Expected indentation of 4 spaces but found 8 indent
28:1 error Expected indentation of 4 spaces but found 8 indent
29:1 error Expected indentation of 4 spaces but found 8 indent
31:1 error Expected indentation of 4 spaces but found 8 indent
32:1 error Expected indentation of 4 spaces but found 8 indent
33:1 error Expected indentation of 4 spaces but found 8 indent
35:1 error Expected indentation of 4 spaces but found 8 indent
36:1 error Expected indentation of 4 spaces but found 8 indent
38:1 error Expected indentation of 4 spaces but found 8 indent
39:1 error Expected indentation of 4 spaces but found 8 indent
40:1 error Expected indentation of 8 spaces but found 12 indent
41:1 error Expected indentation of 8 spaces but found 12 indent
42:1 error Expected indentation of 8 spaces but found 12 indent
43:1 error Expected indentation of 8 spaces but found 12 indent
44:1 error Expected indentation of 8 spaces but found 12 indent
45:1 error Expected indentation of 8 spaces but found 12 indent
45:27 error Missing trailing comma comma-dangle
46:1 error Expected indentation of 4 spaces but found 8 indent
47:1 error Expected indentation of 4 spaces but found 8 indent
48:1 error Expected indentation of 4 spaces but found 8 indent
49:1 error Expected indentation of 4 spaces but found 8 indent
50:1 error Expected indentation of 4 spaces but found 8 indent
52:1 error Expected indentation of 4 spaces but found 8 indent
53:1 error Expected indentation of 4 spaces but found 8 indent
54:1 error Expected indentation of 4 spaces but found 8 indent
55:1 error Expected indentation of 4 spaces but found 8 indent
56:1 error Expected indentation of 4 spaces but found 8 indent
58:1 error Expected indentation of 4 spaces but found 8 indent
59:1 error Expected indentation of 8 spaces but found 12 indent
60:1 error Expected indentation of 8 spaces but found 12 indent
61:1 error Expected indentation of 4 spaces but found 8 indent
63:1 error Expected indentation of 4 spaces but found 8 indent
64:1 error Expected indentation of 8 spaces but found 12 indent
65:1 error Expected indentation of 8 spaces but found 12 indent
66:1 error Expected indentation of 12 spaces but found 16 indent
67:1 error Expected indentation of 8 spaces but found 12 indent
68:1 error Expected indentation of 4 spaces but found 8 indent
70:1 error Expected indentation of 4 spaces but found 8 indent
71:1 error Expected indentation of 4 spaces but found 8 indent
73:1 error Expected indentation of 4 spaces but found 8 indent
74:1 error Expected indentation of 8 spaces but found 12 indent
75:1 error Expected indentation of 12 spaces but found 16 indent
76:1 error Expected indentation of 12 spaces but found 16 indent
77:1 error Expected indentation of 8 spaces but found 12 indent
78:1 error Expected indentation of 12 spaces but found 16 indent
79:1 error Expected indentation of 12 spaces but found 16 indent
80:1 error Expected indentation of 8 spaces but found 12 indent
81:1 error Expected indentation of 4 spaces but found 8 indent
83:1 error Expected indentation of 4 spaces but found 8 indent
84:1 error Expected indentation of 4 spaces but found 8 indent
85:1 error Expected indentation of 4 spaces but found 8 indent
86:1 error Expected indentation of 4 spaces but found 8 indent
87:1 error Expected indentation of 4 spaces but found 8 indent
88:1 error Expected indentation of 4 spaces but found 8 indent
89:1 error Expected indentation of 4 spaces but found 8 indent
90:1 error Expected indentation of 4 spaces but found 8 indent
92:1 error Expected indentation of 4 spaces but found 8 indent
93:1 error Expected indentation of 4 spaces but found 8 indent
94:1 error Expected indentation of 4 spaces but found 8 indent
95:1 error Expected indentation of 4 spaces but found 8 indent
96:1 error Expected indentation of 4 spaces but found 8 indent
97:1 error Expected indentation of 4 spaces but found 8 indent
98:1 error Expected indentation of 4 spaces but found 8 indent
99:1 error Expected indentation of 4 spaces but found 8 indent
101:1 error Expected indentation of 4 spaces but found 8 indent
102:1 error Expected indentation of 4 spaces but found 8 indent
104:1 error Expected indentation of 4 spaces but found 8 indent
105:1 error Expected indentation of 4 spaces but found 8 indent
106:1 error Expected indentation of 4 spaces but found 8 indent
107:1 error Expected indentation of 0 spaces but found 4 indent
113:1 error Missing JSDoc comment jsdoc/require-jsdoc

✖ 87 problems (87 errors, 0 warnings)
85 errors and 0 warnings potentially fixable with the --fix option.

@rvbuelow
Copy link
Author

rvbuelow commented Oct 4, 2025

Care to explain why you close this without merge? I've changed NO code beyond adding the version number in the metadata.json file, which is needed to make this extension work with Gnome 49.

Why would i take ownership for these completely unrelated eslint issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants