-
Notifications
You must be signed in to change notification settings - Fork 61
Add version 49 to shell-version array #200
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
@rvbuelow, fix the eslint errors except for "Extension defined but not used" and I'll merge it |
|
Erm ... none of these errors have anything to do with what i changed. Fix it yourself :D Run npx eslint . --ext .js --ignore-pattern node_modules/ /home/runner/work/wintile/wintile/extension.js /home/runner/work/wintile/wintile/keybindings.js /home/runner/work/wintile/wintile/prefs.js ✖ 87 problems (87 errors, 0 warnings) |
|
Care to explain why you close this without merge? I've changed NO code beyond adding the version number in the metadata.json file, which is needed to make this extension work with Gnome 49. Why would i take ownership for these completely unrelated eslint issues? |
Tested once, works fine for me.