Parse lyrics lines with timestamps 3+ digit minutes#530
Merged
nift4 merged 2 commits intoJun 5, 2025
Conversation
nift4
reviewed
Jun 5, 2025
| LyricLine(start = 186760uL, text = """繋げよう""", words = null, speaker = null, end = 189799uL, isTranslated = false), | ||
| LyricLine(start = 186760uL, text = """Let's connect""", words = null, speaker = null, end = 189799uL, isTranslated = true), | ||
| LyricLine(start = 189800uL, text = """""", words = null, speaker = null, end = 9223372036854775807uL, isTranslated = false), | ||
| LyricLine(start = 6186760uL, text = """Let's connect""", words = null, speaker = null, end = 189799uL, isTranslated = true), |
mikooomich
force-pushed
the
lyrics-greater-than-99-minutes
branch
from
038e7dd to
ae7239b
Compare
Collaborator
Author
|
My bad, tests should be good now. I moved the lrc tests to LrcUtilsTests file, and just replaced the final chorus for ttml with "timestamp +100 minutes". Lmk if anything else is needed |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Would previous read as:
With this change, the timestamp for lyrics with 3+ digits for minutes should be read correctly.