Skip to content

stop using node 16 in pipelines / clear other pipeline warnings #1324

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Mar 12, 2024
Merged
Show file tree
Hide file tree
Changes from 6 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 16 additions & 12 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: CI

env:
PNPM_STORE_PATH: ''

# Runs build and test on:
# every push that has a change in a file not in the docs folder
# every pull request with main branch as the base that has a change
Expand All @@ -16,30 +19,31 @@ jobs:
build:
name: Check and build codebase
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
node-version: 18.x

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- uses: pnpm/[email protected]
- uses: pnpm/action-setup@v3
name: Install pnpm
with:
run_install: false
version: 7

- name: Get pnpm store directory
shell: bash
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"
run: |
echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- name: Setup pnpm cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
Expand All @@ -52,13 +56,13 @@ jobs:
# - name: Clear all caches
# run: pnpm clean:cache

- name: Build Code and Examples ${{ matrix.node-version }}
- name: Build Code and Examples
run: pnpm run build

# We build in-source files like `examples/one-page/index.html`.
# This check ensures we don't build changes that need committing.
- name: Check generated in-source files
run: git diff --no-ext-diff --quiet --exit-code

- name: Check Code ${{ matrix.node-version }}
- name: Check Code
run: pnpm run check:ci
18 changes: 12 additions & 6 deletions .github/workflows/create-spectacle.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: create-spectacle

env:
PNPM_STORE_PATH: ''

on:
push:
branches:
Expand All @@ -24,26 +27,29 @@ jobs:
node-version: [18.x]
create-type: ['tsx', 'onepage']
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
- uses: actions/checkout@v4
- uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- uses: pnpm/[email protected]
- uses: pnpm/action-setup@v3
name: Install pnpm
with:
run_install: false
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"
run: |
echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- name: Setup pnpm cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
Expand Down
17 changes: 11 additions & 6 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,8 @@
name: Spectacle Release Workflow

env:
PNPM_STORE_PATH: ''

on:
push:
branches:
Expand All @@ -18,27 +21,29 @@ jobs:
pull-requests: write

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: 18.x

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
run_install: false
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"
run: |
echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV

- name: Setup pnpm cache
uses: actions/cache@v3
uses: actions/cache@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
path: ${{ env.PNPM_STORE_PATH }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
Expand Down