-
Notifications
You must be signed in to change notification settings - Fork 693
stop using node 16 in pipelines / clear other pipeline warnings #1324
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 6 commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
d71cdc6
stop using node 16
Burnett2k 2a2f66c
use newer action versions
Burnett2k 8871af6
use env vars instead of set-output command
Burnett2k 878d7b5
use newer action versions
Burnett2k 4d82740
use newer version of cache
Burnett2k e7cc577
update release.yml to clear warnings
Burnett2k 97c60ee
simplify ci.yml
Burnett2k 934a22c
simplify create-spectacle.yml
Burnett2k a6e2097
simplify release.yml
Burnett2k eb67833
ensure pnpm is installed first
Burnett2k 15158c6
simplify pnpm setup action config
Burnett2k File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
name: CI | ||
|
||
env: | ||
PNPM_STORE_PATH: '' | ||
|
||
# Runs build and test on: | ||
# every push that has a change in a file not in the docs folder | ||
# every pull request with main branch as the base that has a change | ||
|
@@ -16,30 +19,31 @@ jobs: | |
build: | ||
name: Check and build codebase | ||
runs-on: ubuntu-latest | ||
strategy: | ||
matrix: | ||
node-version: [16.x, 18.x] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
node-version: 18.x | ||
|
||
# Wireit cache | ||
- uses: google/wireit@setup-github-actions-caching/v1 | ||
|
||
- uses: pnpm/[email protected] | ||
- uses: pnpm/action-setup@v3 | ||
name: Install pnpm | ||
with: | ||
run_install: false | ||
version: 7 | ||
|
||
- name: Get pnpm store directory | ||
shell: bash | ||
id: pnpm-cache | ||
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" | ||
run: | | ||
echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
||
- name: Setup pnpm cache | ||
uses: actions/cache@v3 | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} | ||
path: ${{ env.PNPM_STORE_PATH }} | ||
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-pnpm-store- | ||
|
@@ -52,13 +56,13 @@ jobs: | |
# - name: Clear all caches | ||
# run: pnpm clean:cache | ||
|
||
- name: Build Code and Examples ${{ matrix.node-version }} | ||
- name: Build Code and Examples | ||
run: pnpm run build | ||
|
||
# We build in-source files like `examples/one-page/index.html`. | ||
# This check ensures we don't build changes that need committing. | ||
- name: Check generated in-source files | ||
run: git diff --no-ext-diff --quiet --exit-code | ||
|
||
- name: Check Code ${{ matrix.node-version }} | ||
- name: Check Code | ||
run: pnpm run check:ci |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,8 @@ | ||
name: create-spectacle | ||
|
||
env: | ||
PNPM_STORE_PATH: '' | ||
|
||
on: | ||
push: | ||
branches: | ||
|
@@ -24,26 +27,29 @@ jobs: | |
node-version: [18.x] | ||
create-type: ['tsx', 'onepage'] | ||
steps: | ||
- uses: actions/checkout@v2 | ||
- uses: actions/setup-node@v2 | ||
- uses: actions/checkout@v4 | ||
- uses: actions/setup-node@v4 | ||
with: | ||
node-version: ${{ matrix.node-version }} | ||
|
||
# Wireit cache | ||
- uses: google/wireit@setup-github-actions-caching/v1 | ||
|
||
- uses: pnpm/[email protected] | ||
- uses: pnpm/action-setup@v3 | ||
name: Install pnpm | ||
with: | ||
run_install: false | ||
Burnett2k marked this conversation as resolved.
Show resolved
Hide resolved
|
||
version: 7 | ||
|
||
- name: Get pnpm store directory | ||
id: pnpm-cache | ||
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)" | ||
run: | | ||
echo "PNPM_STORE_PATH=$(pnpm store path --silent)" >> $GITHUB_ENV | ||
|
||
- name: Setup pnpm cache | ||
uses: actions/cache@v3 | ||
uses: actions/cache@v4 | ||
with: | ||
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }} | ||
path: ${{ env.PNPM_STORE_PATH }} | ||
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }} | ||
restore-keys: | | ||
${{ runner.os }}-pnpm-store- | ||
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.