Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

stop using node 16 in pipelines / clear other pipeline warnings #1324

Merged
merged 11 commits into from
Mar 12, 2024
34 changes: 11 additions & 23 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -16,33 +16,21 @@ jobs:
build:
name: Check and build codebase
runs-on: ubuntu-latest
strategy:
matrix:
node-version: [16.x, 18.x]
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
run_install: false
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: 18.x

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- name: Install dependencies
run: pnpm install
Expand All @@ -52,13 +40,13 @@ jobs:
# - name: Clear all caches
# run: pnpm clean:cache

- name: Build Code and Examples ${{ matrix.node-version }}
- name: Build Code and Examples
run: pnpm run build

# We build in-source files like `examples/one-page/index.html`.
# This check ensures we don't build changes that need committing.
- name: Check generated in-source files
run: git diff --no-ext-diff --quiet --exit-code

- name: Check Code ${{ matrix.node-version }}
- name: Check Code
run: pnpm run check:ci
27 changes: 9 additions & 18 deletions .github/workflows/create-spectacle.yml
Original file line number Diff line number Diff line change
Expand Up @@ -24,29 +24,20 @@ jobs:
node-version: [18.x]
create-type: ['tsx', 'onepage']
steps:
- uses: actions/checkout@v2
- uses: actions/setup-node@v2
with:
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1
- uses: actions/checkout@v4

- uses: pnpm/action-setup@v2.2.2
- uses: pnpm/action-setup@v3
with:
run_install: false
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('./pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: ${{ matrix.node-version }}

# Wireit cache
- uses: google/wireit@setup-github-actions-caching/v1

- name: Install dependencies
run: pnpm install
Expand Down
23 changes: 6 additions & 17 deletions .github/workflows/release.yml
Original file line number Diff line number Diff line change
Expand Up @@ -18,30 +18,19 @@ jobs:
pull-requests: write

steps:
- uses: actions/checkout@v2
- uses: actions/checkout@v4
with:
fetch-depth: 0

- name: Use Node.js
uses: actions/setup-node@v1
with:
node-version: 18.x

- uses: pnpm/[email protected]
- uses: pnpm/action-setup@v3
with:
run_install: false
version: 7

- name: Get pnpm store directory
id: pnpm-cache
run: echo "::set-output name=pnpm_cache_dir::$(pnpm store path)"

- name: Setup pnpm cache
uses: actions/cache@v3
- uses: actions/setup-node@v4
with:
path: ${{ steps.pnpm-cache.outputs.pnpm_cache_dir }}
key: ${{ runner.os }}-pnpm-store-${{ hashFiles('**/pnpm-lock.yaml') }}
restore-keys: |
${{ runner.os }}-pnpm-store-
cache: 'pnpm'
node-version: 18.x

- name: Install dependencies
run: pnpm install
Expand Down