Fix: if user provided y domain, don't modify it

[amitkumar]

Description

• Make isNice param to makeScale conditional, false if user y domain is defined.

Fixes # (issue)

Type of Change

• Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

• Added a unit test for transformInputData to verify that user-defined domain is preserved.

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
victory-native-xl-docs	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 12, 2024 11:38pm

[zibs]

Hey @amitkumar -- do you mind adding some screenshots/description of what this change looks like, or updating/adding an example chart in the example app screens inside the repo? Thanks for the test too!

[derekpwu]

Just sharing some findings and our workaround:
We used a similar approach to ensure that the y-axises stay at the same place when switching between different graphs. It looks like if we adjust the padding and apply nicing, it changes the position of all the y-axis. This causes an UI issue in our use case, where the y-axis jumps to different spots when you switch between different graphs; on the other hand, completely removing nicing would resulted in missing top or bottom ticks in some cases due to losing the benefit of nicing. To workaround this, we apply nicing just before the padding adjustment. This appears to work, but not sure about other implications.
I believe the key aspect here might be the padding adjustment. Would it be possible to apply padding without domain adjustment?

Screen.Recording.2024-02-27.at.8.33.48.PM.mov