Skip to content

feat: render custom x/y axis nodes#470

Closed
zibs wants to merge 10 commits into
mainfrom
feat/axis-images
Closed

feat: render custom x/y axis nodes#470
zibs wants to merge 10 commits into
mainfrom
feat/axis-images

Conversation

@zibs

@zibs zibs commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator

Description

allows users to pass in a renderXLabel or renderYLabel prop to either x or y axis which allows them to render anything they want.

Screenshot 2025-01-09 at 8 35 36 AM Screenshot 2025-01-09 at 8 35 30 AM

Fixes #309

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot

changeset-bot Bot commented Jan 9, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 8765258

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Jan 9, 2025

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:07pm

@keithluchtel keithluchtel left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bigger question, thoughts on updating formatYLabel to allow users to return Skia components instead of limiting it only a string? This would allow users to handle drawing images, but would also allow them to return custom text components (such as paragraph to support line breaks.

Comment thread lib/src/cartesian/components/YAxis.tsx Outdated
@zibs

zibs commented Jan 9, 2025

Copy link
Copy Markdown
Collaborator Author

Take a look at the last PR and see if this is along the lines of what we might want. It allows for Text/Paragraph/Image etc.

Screenshot 2025-01-09 at 12 08 31 PM

Comment thread lib/src/types.ts Outdated
Comment thread lib/src/cartesian/components/AxisImage.tsx Outdated
Comment thread example/app/axis-images.tsx Outdated
@zibs zibs changed the title feat: add axis images feat: render custom x/y axis nodes Jan 13, 2025
@mangos1234

Copy link
Copy Markdown

Hey! Just wondering if there's an estimated timeline for when this PR might be merged, I would love to use this feature.

@davkub

davkub commented Oct 15, 2025

Copy link
Copy Markdown

Hey, we would love to use this feature too. There are a few PRs that have been lingering here for some time that users would really appreciate since many had to migrate from old victory to new one due to library support

@shmkane

shmkane commented Oct 28, 2025

Copy link
Copy Markdown

This would be useful. Any updates?

@zibs zibs mentioned this pull request Jun 3, 2026
13 tasks
@zibs

zibs commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator Author

Closing for #672

@zibs zibs closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Can we add image or icon on y-axis

7 participants