Skip to content

Comments

Fix/bar path adjustment#478

Merged
zibs merged 3 commits intomainfrom
fix/bar-path-adjustment
Jan 24, 2025
Merged

Fix/bar path adjustment#478
zibs merged 3 commits intomainfrom
fix/bar-path-adjustment

Conversation

@zibs
Copy link
Contributor

@zibs zibs commented Jan 16, 2025

Description

Fixes an issue where we were double adjusting a x value for bar group paths

Fixes #475

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Before:
You can see it's shifted
Screenshot 2025-01-16 at 2 38 25 PM

After:
It's now centered
Screenshot 2025-01-16 at 1 51 17 PM

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

zibs added 2 commits January 16, 2025 13:55
Stops adjusting how we handle the `x` value inside `createRoundedRectPath` and move that work to the caller of the function.

We were double adjusting in certain cases (bar groups) and this was moving the bars off center.
@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2025

🦋 Changeset detected

Latest commit: 6861797

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 16, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 21, 2025 9:07pm

@zibs zibs requested a review from keithluchtel January 16, 2025 22:41
@zibs zibs merged commit c77a3a1 into main Jan 24, 2025
3 checks passed
@zibs zibs deleted the fix/bar-path-adjustment branch January 24, 2025 16:40
@fmd-ci fmd-ci mentioned this pull request Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

labels and chart padding seem to be off

3 participants