Skip to content

Comments

Feat/improve area range#488

Merged
zibs merged 4 commits intoFormidableLabs:mainfrom
rvieceli:feat/improve-area-range
Feb 4, 2025
Merged

Feat/improve area range#488
zibs merged 4 commits intoFormidableLabs:mainfrom
rvieceli:feat/improve-area-range

Conversation

@rvieceli
Copy link
Contributor

Description

It changes AreaRange component by adding upperPoints and lowerPoints as an alternative to points map, but it does not change how points map works.
It also adds a page for AreaRange component and removes from LineChart

Fixes #487

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

It kept to the old example and added a new one using the same data, making sure old and new works as

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

@changeset-bot
Copy link

changeset-bot bot commented Jan 29, 2025

🦋 Changeset detected

Latest commit: eaf471b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Jan 29, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
victory-native-xl-docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 4, 2025 9:11pm

Copy link
Contributor

@zibs zibs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @rvieceli -- this seems good to me -- @keithluchtel thoughts?

@keithluchtel
Copy link
Contributor

Thanks for the PR @rvieceli -- this seems good to me -- @keithluchtel thoughts?

LGTM!

@zibs zibs merged commit 7c1348e into FormidableLabs:main Feb 4, 2025
3 checks passed
@fmd-ci fmd-ci mentioned this pull request Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add lower and upper points to AreaRange

3 participants