-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose gestureHandlerConfig prop in CartesianChart for gesture custom… #517
base: main
Are you sure you want to change the base?
Expose gestureHandlerConfig prop in CartesianChart for gesture custom… #517
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Thanks @vasylmar - can you add a changeset (minor)? |
🦋 Changeset detectedLatest commit: 8484b34 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
lib/src/cartesian/CartesianChart.tsx
Outdated
@@ -83,6 +84,7 @@ type CartesianChartProps< | |||
chartPressConfig?: { | |||
pan?: ChartPressPanConfig; | |||
}; | |||
gestureHandlerConfig: GestureHandlerConfig; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should be optional
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I’ve updated the gestureHandlerConfig to be optional in the latest commit.
Also feel free to hit the update branch button |
Description
This PR enhances the
CartesianChart
component by introducing a newgestureHandlerConfig
prop. This allows users to customize gesture handling behavior via theGestureHandlerConfig
type.Resolves #516
Type of Change
GestureHandlerConfig
to provide better type safety.gestureHandlerConfig
prop toGestureHandler
so it can accept custom configurations.gestureHandlerConfig
inCartesianChart
and passed it down toGestureHandler
.How Has This Been Tested?
Let me know if any additional testing is required! 🚀
Checklist: (Feel free to delete this section upon completion)
yarn run check:code
and all checks pass