Skip to content

Comments

Fix/on layout view#621

Merged
zibs merged 4 commits intomainfrom
fix/on-layout-view
Sep 8, 2025
Merged

Fix/on layout view#621
zibs merged 4 commits intomainfrom
fix/on-layout-view

Conversation

@zibs
Copy link
Contributor

@zibs zibs commented Sep 3, 2025

Description

Fixes #615

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

zibs added 2 commits September 3, 2025 11:51
hearing reports that this was not working in a variety of situations (prod, dev, potentially versions)
@zibs zibs requested a review from keithluchtel September 3, 2025 18:52
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: b2a306f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Sep 3, 2025

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Preview Comments Updated (UTC)
victory-native-xl-docs Ready Ready Preview Comment Sep 5, 2025 8:22pm

@zibs
Copy link
Contributor Author

zibs commented Sep 3, 2025

@danielcrk -- is this the correct diff?

@danielcrk
Copy link

is this the correct diff?

@zibs Looks good to me!
(I don't think the additional overflow: 'hidden' is needed, tho.)

@zibs zibs merged commit edca15a into main Sep 8, 2025
3 checks passed
@zibs zibs deleted the fix/on-layout-view branch September 8, 2025 16:11
@github-actions github-actions bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Chart renders properly in debug mode, but blank in prod builds

3 participants