Skip to content

feat(axis): Add multiline axis label support with proper spacing#645

Closed
rajdivergenceneuro wants to merge 3 commits into
FormidableLabs:mainfrom
rajdivergenceneuro:add-multiline-axis-support
Closed

feat(axis): Add multiline axis label support with proper spacing#645
rajdivergenceneuro wants to merge 3 commits into
FormidableLabs:mainfrom
rajdivergenceneuro:add-multiline-axis-support

Conversation

@rajdivergenceneuro

@rajdivergenceneuro rajdivergenceneuro commented Dec 16, 2025

Copy link
Copy Markdown
Contributor

Description

  • Add multiline axis label support for both X and Y axes using newline characters and string arrays
  • Update CartesianAxis component to handle multiline labels with proper width calculation per line
  • Implement dynamic label positioning that accounts for individual line widths in multiline scenarios
  • Add new example route demonstrating multiline axis labels with months and performance metrics
  • Update type definitions to support string array format for axis labels
  • Improve label offset and spacing calculations for better visual alignment of multiline text
  • Add changeset entry documenting the new multiline axis label feature

Fixes # (issue)

  • Resolved multiline issue.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Checklist: (Feel free to delete this section upon completion)

  • I have included a changeset if this change will require a version change to one of the packages.
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have run yarn run check:code and all checks pass
  • I have created a changeset for new features, patches, or major changes
  • I have added tests that prove my fix is effective or that my feature works
  • My changes generate no new warnings
  • Any dependent changes have been merged and published in downstream modules

- Add multiline axis label support for both X and Y axes using newline characters and string arrays
- Update CartesianAxis component to handle multiline labels with proper width calculation per line
- Implement dynamic label positioning that accounts for individual line widths in multiline scenarios
- Add new example route demonstrating multiline axis labels with months and performance metrics
- Update type definitions to support string array format for axis labels
- Improve label offset and spacing calculations for better visual alignment of multiline text
- Add changeset entry documenting the new multiline axis label feature
@changeset-bot

changeset-bot Bot commented Dec 16, 2025

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: c5ac82f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
example Patch
victory-native Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel

vercel Bot commented Dec 16, 2025

Copy link
Copy Markdown

@rajdivergenceneuro is attempting to deploy a commit to the formidable-labs Team on Vercel.

A member of the Team first needs to authorize it.

@umeshpatil01269

umeshpatil01269 commented May 8, 2026

Copy link
Copy Markdown

@rajdivergenceneuro
This is a much-needed feature for multiline axis labels!

I'm following this PR and was wondering about the expected timeline for when it might be merged and released.

I see the Vercel deployment check requires authorization, and the PR is still waiting for an approving review. Are there any specific blockers or additional changes needed before this can be merged?

@zibs

zibs commented May 8, 2026

Copy link
Copy Markdown
Collaborator

Thanks y'all, sorry for the delays here, I'm hoping to have a bit more time to squeeze in some of these fixes, thank you for the patience!

@zibs zibs mentioned this pull request Jun 3, 2026
13 tasks
@zibs

zibs commented Jun 4, 2026

Copy link
Copy Markdown
Collaborator

Closing for #672 - Thanks for your contribution! I implemented most of this on that PR but not all of it.

@zibs zibs closed this Jun 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants