Fix NumPy 2.0 deprecation: replace np.trapz with np.trapezoid#35
Merged
Conversation
Member
Author
|
readthedocs build failed, but unrelated to changes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request updates the numerical integration method used in the
CalcBandFluxesfunction ofsrc/mors/spectrum.py. The change replaces the deprecatednp.trapzfunction with the newernp.trapezoidfunction from NumPy to ensure compatibility with recent versions of the library. Related to FormingWorlds/PROTEUS#568. @stuitje @nichollsh This addresses one issue discussed on Discord and in FormingWorlds/PROTEUS#575, but not the other issue that @stuitje is working on inside MORS. Apologies for me stumbling into this, but I had to fix this quickly to be able to move on with some other PROTEUS-level implementation.Numerical integration method update:
np.trapzwithnp.trapezoidfor integrating flux over wavelength bands and for the bolometric band in theCalcBandFluxesmethod.